Re: CVS Commit by andreas: Fix reading/writing bool config values

> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> cvs(at)developer(dot)pgadmin(dot)org
> Sent: 29 March 2005 18:43
> To: pgadmin-hackers(at)postgresql(dot)org
> Subject: [pgadmin-hackers] CVS Commit by andreas: Fix
> reading/writing bool config values
>
> Log Message:
> -----------
> Fix reading/writing bool config values
>
> Modified Files:
> --------------
> pgadmin3/src/include:
> sysSettings.h (r1.37 -> r1.38)
> pgadmin3/src/ui:
> frmMain.cpp (r1.124 -> r1.125)
> pgadmin3/src/utils:
> sysSettings.cpp (r1.69 -> r1.70)

Oops. This seems to break things somewhat on win32:

sysSettings.cpp
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\sysSettings.cpp(162) : warning C4800:
'unsigned short *' : forcing value to bool 'true' or 'false'
(performance warning)
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\sysSettings.cpp(164) : warning C4800:
'unsigned short *' : forcing value to bool 'true' or 'false'
(performance warning)
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\sysSettings.cpp(170) : warning C4800:
'unsigned short *' : forcing value to bool 'true' or 'false'
(performance warning)
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\sysSettings.cpp(173) : warning C4800:
'unsigned short *' : forcing value to bool 'true' or 'false'
(performance warning)
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\sysSettings.cpp(176) : warning C4800:
'unsigned short *' : forcing value to bool 'true' or 'false'
(performance warning)
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\sysSettings.cpp(185) : warning C4800:
'const unsigned short *' : forcing value to bool 'true' or 'false'
(performance warning)
Generating Code...
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\sysSettings.cpp(211) : error C4716:
'sysSettings::Write' : must return a value
Compiling...
update.cpp
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\utils\update.cpp(54) : warning C4800: 'const
unsigned short *' : forcing value to bool 'true' or 'false' (performance
warning)
dlgAggregate.cpp

...
...

frmHint.cpp
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\ui\frmHint.cpp(126) : warning C4800:
'unsigned short *' : forcing value to bool 'true' or 'false'
(performance warning)
C:\Documents and Settings\dpage\My
Documents\CVS\pgadmin3\src\ui\frmHint.cpp(145) : warning C4800: 'const
unsigned short *' : forcing value to bool 'true' or 'false' (performance
warning)

Regards, Dave.