Skip site navigation (1) Skip section navigation (2)

Re: pg_autovacuum/Win32 Fixes

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Neil Conway" <neilc(at)samurai(dot)com>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_autovacuum/Win32 Fixes
Date: 2005-01-22 20:51:00
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E45285C1@ratbert.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgsql-patches
 

> -----Original Message-----
> From: Neil Conway [mailto:neilc(at)samurai(dot)com] 
> Sent: 22 January 2005 10:13
> To: Dave Page
> Cc: pgsql-patches(at)postgresql(dot)org
> Subject: Re: [PATCHES] pg_autovacuum/Win32 Fixes
> 
> Dave Page wrote:
> > Theis patch supercedes *all* my earlier ones from today - 
> apologies for
> > the noise, clearly I need a beer or 3 and a few nights away from the
> > laptop.
> 
> @@ -1166,7 +1166,9 @@
>   		exit(0);
>   #ifdef WIN32
>   	case 'E':
> -		args->service_dependencies = optarg;
> +		ZeroMemory(deps, sizeof(deps));
> +		snprintf(deps, sizeof(deps) - 2, "%s", optarg);
> +		args->service_dependencies = (char *)deps;
>   		break;
>   	case 'I':
>   		args->install_as_service++;
> 
> After googling around I can see what this code is intended to 
> do; in the 
> future a comment might be nice. 

Sorry - as you probably noticed it was one of 'those days'.

> Also, why not strncpy()?

No reason, just a hangover from some experimentation I was doing. I've
no objections if you want to change it.

> Barring any objections I'll apply this patch to REL8_0_STABLE 
> and HEAD 
> on Monday.

Thanks, Dave.

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-01-22 21:19:16
Subject: Re: Much Ado About COUNT(*)
Previous:From: Euler Taveira de OliveiraDate: 2005-01-22 20:36:27
Subject: Re: [PATCHES] Merge pg_shadow && pg_group -- UNTESTED

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group