From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
---|---|
To: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Cannot initdb in cvs tip |
Date: | 2004-07-28 08:50:14 |
Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E41A74AE@ratbert.vale-housing.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: 28 July 2004 09:29
> To: Dave Page
> Cc: Tom Lane; PostgreSQL-development; pgsql-patches(at)postgresql(dot)org
> Subject: Re: [HACKERS] Cannot initdb in cvs tip
>
>
> Dave, now that we are nearing beta, I think we need to
> correct the initdb problem with removing the directory on
> Win32. Would you code this up as something that sits in
> /port/dirmod.c and have both initdb and DROP DATABASE call
> the C routine rather than call rm -r/rmdir? (I think those
> are the only two. DROP TABLESPACE?)
I'm pretty busy right now and can't guarantee I'll even be able to look
at this until Friday (I spent the last 2 days on pg stuff so need to do
some other things at work :-( ). If anyone has more time please shout,
otherwise I'll get to this as soon as I can.
> I wanted to keep a solution that was as native to the OS as
> possible, but because we can't do that on Win32 and few
> people like the unix system call to 'rm', it is time to clean it up.
Yup.
> One question --- why is there a sleep loop needed for unlink
> in your patch?
I don't know - which leads me nicely onto point out that it's not my
patch :-) I think it was Andrew that orginally wrote it - I just created
the patch to put it back in after it was removed.
Regards, Dave.
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-07-28 12:39:15 | Re: [HACKERS] Cannot initdb in cvs tip |
Previous Message | Bruce Momjian | 2004-07-28 08:29:28 | Re: [HACKERS] Cannot initdb in cvs tip |
From | Date | Subject | |
---|---|---|---|
Next Message | Brian B. | 2004-07-28 09:07:46 | Some release notes corrections. |
Previous Message | Bruce Momjian | 2004-07-28 08:29:28 | Re: [HACKERS] Cannot initdb in cvs tip |