Re: Paste rows patch

> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> Edward Di Geronimo Jr.
> Sent: 10 May 2006 16:41
> To: pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] Paste rows patch
>
> Quoting Dave Page <dpage(at)vale-housing(dot)co(dot)uk>:
>
> > Nice - that works. Unfortunately I found another problem -
> the serial
> > column doesn't seem to work I suspect because you are looking for
> > columns that are PGOID_TYPE_SERIAL or PGOID_TYPE_SERIAL8,
> however they
> > actually get seen as int4's or int8's I believe. I'm testing with
> > 8.1.3 and a table that looks like:
>
> That's odd. It works for me with Postgres 8.0.7. In the
> sqlTable constructor, pgAdmin looks at the types and sets the
> type to one of those serial types if it detects a nextval()
> attached to the column.
> Looks like that detection doesn't work for 8.1.
>
> Could you look at fixing that? Roughly around line 1150 in
> frmEditGrid.cpp.

Ah, yes - it was assuming a schema was always prepended to the sequence
name, and that the name was cast to text which is no longer the case in
8.1 (it's now cast to regclass). I modified it to detect both with or
without schema, cast to text or regclass.

And with that, another new feature is added :-). Thanks Ed. Patch
applied.

Regards, Dave.