Re: [Fwd: Grid code cleanup]

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Edward Di Geronimo Jr(dot)" <edigeronimo(at)xtracards(dot)com>
Cc: <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Fwd: Grid code cleanup]
Date: 2006-03-20 15:06:58
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4011C9601@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Ed, patch applied with a couple of minor changes

- VC++ 6.0 precompiled header compatibility
- Add new files to *nix build.

Regards, Dave

>
> > -----Original Message-----
> > From: Edward Di Geronimo Jr. [mailto:edigeronimo(at)xtracards(dot)com]
> > Sent: 16 March 2006 17:19
> > To: Dave Page
> > Subject: [Fwd: Grid code cleanup]
> >
> > Here's the original email I sent to the list. I was wondering why it
> > wasn't coming through...
> >
> > Ed
> >
> > ---------------------------- Original Message
> > ----------------------------
> > Subject: Grid code cleanup
> > From: "Edward Di Geronimo Jr." <edigeronimo(at)xtracards(dot)com>
> > Date: Wed, March 15, 2006 1:47 pm
> > To: pgadmin-hackers(at)postgresql(dot)org
> > --------------------------------------------------------------
> > ------------
> >
> > Hi all,
> >
> > Here's a patch to do some cleanup on the code for the two
> > different grid
> > controls. Here's a summary of the changes:
> >
> > * ctlSQLGrid renamed to ctlSQLEditGrid
> >
> > * ctlSQLResult and ctlSQLEditGrid are now derived from a new class,
> > ctlSQLGrid
> >
> > * Clipboard code for both grid classes moved into ctlSQLGrid
> >
> > * Support for resizing columns to best fit width when the
> > label is double
> > clicked moved into ctlSQLGrid, which adds the feature to the
> > results grid.
> >
> > * Custom table class removed from ctlSQLResult. Some of the
> > later changes
> > I made as part of the previous patch ended up making the
> default table
> > faster than the custom one. It seems that the bottleneck in
> wxGrid is
> > AppendRows(). If you minimize your calls to that it will
> perform very
> > well.
> >
> > Ed
> >
>

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2006-03-20 15:30:44 Anyone got an Intel Mac yet?
Previous Message svn 2006-03-20 15:05:32 SVN Commit by dpage: r5057 - in trunk/pgadmin3: . src/ctl src/dlg src/frm src/include src/include/ctl