From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
---|---|
To: | "Edward Di Geronimo Jr(dot)" <edigeronimo(at)xtracards(dot)com>, "Magnus Hagander" <mha(at)sollentuna(dot)net> |
Cc: | <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Improved copying from Edit Data Grid - rough |
Date: | 2006-02-06 10:49:39 |
Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E40103DEB3@ratbert.vale-housing.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> Edward Di Geronimo Jr.
> Sent: 03 February 2006 20:02
> To: Magnus Hagander
> Cc: pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] Improved copying from Edit
> Data Grid - rough
>
> Magnus Hagander wrote:
>
> >It think the quoting used when copy here should be the one from Copy
> >Quoting and not Export Quoting. I actually had it on my list
> to do that.
> >While you're working in taht code anyway, maybe do that while at it?
> >
> >
> Ok, I went back and did that as well. While in the process, I noticed
> that the setting to quote only strings also resulted in numbers being
> quoted. I redid the logic to fix that.
>
> >Does this also fix the complete weirdness that you can have
> *both* a row
> >*and* a cell in a different row selected at the same time? That keeps
> >throwing me off all the time.
> >
> >
> I didn't change the selection behavior at all, only the copy behavior.
>
> This version of the patch cleans up the code from my last patch. I
> changed the 3 overloaded versions of GetExportLine so that only 1
> version does the real work. The other two versions simply modify the
> input and call the real version.
>
> One other addition in this version - if you hit copy without
> any cells
> highlighted, it will copy the cell the cursor is in.
Sorry for taking a while to get to this.
Patch applied, with a minor change to make a couple of ints unsigned to
avoid compiler warnings. If you'd like to look at adding similar
functionality to the query tool, that'd be great :-)
Thanks Ed.
Regards, Dave.
From | Date | Subject | |
---|---|---|---|
Next Message | svn | 2006-02-06 11:04:57 | SVN Commit by dpage: r4989 - in trunk/pgadmin3: . src/frm |
Previous Message | svn | 2006-02-06 10:37:57 | SVN Commit by dpage: r4988 - in trunk/pgadmin3: . src/frm src/include |