Re: Odbcapi30.c - 64 bit compiler warning cleanup

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Ludek Finstrle" <luf(at)pzkagis(dot)cz>, <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Odbcapi30.c - 64 bit compiler warning cleanup
Date: 2006-01-26 16:53:38
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E40103DB66@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: 26 January 2006 15:57
> To: Dave Page
> Cc: Ludek Finstrle; pgsql-odbc(at)postgresql(dot)org
> Subject: Re: [ODBC] Odbcapi30.c - 64 bit compiler warning cleanup
>
> "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> >> From: Ludek Finstrle [mailto:luf(at)pzkagis(dot)cz]
> >> I don't solve the problem in options.c where 64-bit pointer may
> >> be passwd throught 32-bit number. I don't know how to solve it.
>
> > No nor I. Any chance of a little help with this one please Tom?
>
> I assume that you can't alter the signature of PGAPI_SetConnectOption,
> ie, vParam really has to be SQLUINTEGER and not some other type?

The spec actually says it should be a SQLPOINTER. Changing to that
unleashes a whole barrel of extra fun unfortunately.

> If so, I'd argue that that whole block (the "if (fOption == 30002 &&
> vParam)" stuff) ought to be #ifdef WIN32. It's certainly useless on
> any other platform,

That's a good point - it didn't even cross my mind that that code is
only useful on Windows. Thanks Tom!

> and Microsoft is never going to figure out how
> to 64-bit-ify that pile of junk they call an OS, so no need to bend
> our brains wondering how this would work on 64-bit Windows.

There have been 64bit versions of Windows for Itanium for ages, and
2003/XP have also been readily available now for a few months. That
said, psqlODBC definitely doesn't support 64 bit builds on Windows yet.

Regards, Dave

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Dave Page 2006-01-26 17:07:12 Re: Odbcapi30.c - 64 bit compiler warning cleanup
Previous Message Tom Lane 2006-01-26 15:57:13 Re: Odbcapi30.c - 64 bit compiler warning cleanup