Skip site navigation (1) Skip section navigation (2)

pgsql: Improve handling of INT_MIN / -1 and related cases.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve handling of INT_MIN / -1 and related cases.
Date: 2012-11-20 02:22:34
Message-ID: E1TadTu-00049V-2W@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Improve handling of INT_MIN / -1 and related cases.

Some platforms throw an exception for this division, rather than returning
a necessarily-overflowed result.  Since we were testing for overflow after
the fact, an exception isn't nice.  We can avoid the problem by treating
division by -1 as negation.

Add some regression tests so that we'll find out if any compilers try to
optimize away the overflow check conditions.

Back-patch of commit 1f7cb5c30983752ff8de833de30afcaee63536d0.

Per discussion with Xi Wang, though this is different from the patch he
submitted.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/3352e25e85b28ee1f21e0a759c0c49e399cb032a

Modified Files
--------------
src/backend/utils/adt/int.c                        |  113 +++++++++++---------
src/backend/utils/adt/int8.c                       |   59 +++++++----
src/test/regress/expected/int2.out                 |   11 ++
src/test/regress/expected/int4.out                 |   21 ++++
.../regress/expected/int8-exp-three-digits.out     |   21 ++++
src/test/regress/expected/int8.out                 |   21 ++++
src/test/regress/sql/int2.sql                      |    4 +
src/test/regress/sql/int4.sql                      |    8 ++
src/test/regress/sql/int8.sql                      |    8 ++
9 files changed, 198 insertions(+), 68 deletions(-)

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2012-11-21 14:05:04
Subject: pgsql: Speed up operations on numeric,mostly by avoiding palloc() over
Previous:From: Tom LaneDate: 2012-11-20 02:22:33
Subject: pgsql: Improve handling of INT_MIN / -1 and related cases.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group