Skip site navigation (1) Skip section navigation (2)

pgsql: Check for stack overflow in transformSetOperationTree().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Check for stack overflow in transformSetOperationTree().
Date: 2012-11-12 00:57:05
Message-ID: E1TXiKn-0003tt-Pd@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Check for stack overflow in transformSetOperationTree().

Since transformSetOperationTree() recurses, it can be driven to stack
overflow with enough UNION/INTERSECT/EXCEPT clauses in a query.  Add a
check to ensure it fails cleanly instead of crashing.  Per report from
Matthew Gerber (though it's not clear whether this is the only thing
going wrong for him).

Historical note: I think the reasoning behind not putting a check here in
the beginning was that the check in transformExpr() ought to be sufficient
to guard the whole parser.  However, because transformSetOperationTree()
recurses all the way to the bottom of the set-operation tree before doing
any analysis of the statement's expressions, that check doesn't save it.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/fae09422fdb97ef2bfbfffcd2abc30060a9c1f51

Modified Files
--------------
src/backend/parser/analyze.c |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

pgsql-committers by date

Next:From: Peter EisentrautDate: 2012-11-12 04:41:14
Subject: pgsql: doc: "only relevant" -> "relevant only"
Previous:From: User FxjrDate: 2012-11-10 00:17:31
Subject: npgsql - Npgsql2: [#1011271] NpgsqlSchema: Use InvariantCulture on all

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group