pgsql: Split up process latch initialization for more-fail-soft behavio

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Split up process latch initialization for more-fail-soft behavio
Date: 2012-10-15 03:00:21
Message-ID: E1TNauj-0003zJ-2b@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Split up process latch initialization for more-fail-soft behavior.

In the previous coding, new backend processes would attempt to create their
self-pipe during the OwnLatch call in InitProcess. However, pipe creation
could fail if the kernel is short of resources; and the system does not
recover gracefully from a FATAL error right there, since we have armed the
dead-man switch for this process and not yet set up the on_shmem_exit
callback that would disarm it. The postmaster then forces an unnecessary
database-wide crash and restart, as reported by Sean Chittenden.

There are various ways we could rearrange the code to fix this, but the
simplest and sanest seems to be to split out creation of the self-pipe into
a new function InitializeLatchSupport, which must be called from a place
where failure is allowed. For most processes that gets called in
InitProcess or InitAuxiliaryProcess, but processes that don't call either
but still use latches need their own calls.

Back-patch to 9.1, which has only a part of the latch logic that 9.2 and
HEAD have, but nonetheless includes this bug.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/eb5e0d8488451bcfcf81e26fd82dd9687c99b941

Modified Files
--------------
src/backend/port/unix_latch.c | 72 ++++++++++++++++++++------------------
src/backend/port/win32_latch.c | 6 +++
src/backend/storage/lmgr/proc.c | 14 +++++++
src/include/storage/latch.h | 1 +
4 files changed, 59 insertions(+), 34 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-10-15 07:59:54 pgsql: Fix race condition in pg_ctl reading postmaster.pid.
Previous Message Tom Lane 2012-10-12 20:14:53 pgsql: Fix oversight in new code for printing rangetable aliases.