pgsql: refactor ALTER some-obj SET OWNER implementation

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: refactor ALTER some-obj SET OWNER implementation
Date: 2012-10-03 21:22:21
Message-ID: E1TJWOb-0007GM-NQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

refactor ALTER some-obj SET OWNER implementation

Remove duplicate implementation of catalog munging and miscellaneous
privilege and consistency checks. Instead rely on already existing data
in objectaddress.c to do the work.

Author: KaiGai Kohei
Tweaked by me
Reviewed by Robert Haas

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/994c36e01d19dece2b0c76fb781e1d08a6e1c814

Modified Files
--------------
src/backend/catalog/pg_largeobject.c | 102 ------------
src/backend/catalog/pg_shdepend.c | 64 ++++----
src/backend/commands/aggregatecmds.c | 15 --
src/backend/commands/alter.c | 288 +++++++++++++++++++++++++++------
src/backend/commands/collationcmds.c | 101 ------------
src/backend/commands/conversioncmds.c | 101 ------------
src/backend/commands/extension.c | 92 -----------
src/backend/commands/functioncmds.c | 137 ----------------
src/backend/commands/opclasscmds.c | 248 ----------------------------
src/backend/commands/operatorcmds.c | 93 -----------
src/backend/commands/proclang.c | 117 -------------
src/backend/commands/tablespace.c | 99 -----------
src/backend/commands/tsearchcmds.c | 120 --------------
src/backend/nodes/copyfuncs.c | 1 -
src/backend/nodes/equalfuncs.c | 1 -
src/backend/parser/gram.y | 4 +-
src/include/catalog/pg_largeobject.h | 1 -
src/include/commands/alter.h | 4 +
src/include/commands/collationcmds.h | 2 -
src/include/commands/conversioncmds.h | 2 -
src/include/commands/defrem.h | 12 --
src/include/commands/proclang.h | 2 -
src/include/commands/tablespace.h | 1 -
src/include/nodes/parsenodes.h | 1 -
24 files changed, 270 insertions(+), 1338 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-10-03 23:47:26 pgsql: Support CREATE SCHEMA IF NOT EXISTS.
Previous Message Tom Lane 2012-10-03 17:38:52 pgsql: Avoid planner crash/Assert failure with joins to unflattened sub