Skip site navigation (1) Skip section navigation (2)

pgsql: Fix line end mishandling in pg_upgrade on Windows.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix line end mishandling in pg_upgrade on Windows.
Date: 2012-09-05 21:50:32
Message-ID: E1T9NUW-0000cT-Qb@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ea0b414a0d9caaad1b7f39acd57708895c4dd0f3

Modified Files
--------------
contrib/pg_upgrade/dump.c |   12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)

pgsql-committers by date

Next:From: Andrew DunstanDate: 2012-09-05 21:50:48
Subject: pgsql: Fix line end mishandling in pg_upgrade on Windows.
Previous:From: Tom LaneDate: 2012-09-05 20:44:28
Subject: pgsql: Restore SIGFPE handler after initializing PL/Perl.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group