Skip site navigation (1) Skip section navigation (2)

pgsql: Split tuple struct defs from htup.h to htup_details.h

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Split tuple struct defs from htup.h to htup_details.h
Date: 2012-08-30 20:54:57
Message-ID: E1T7BlR-0000Gu-1L@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Split tuple struct defs from htup.h to htup_details.h

This reduces unnecessary exposure of other headers through htup.h, which
is very widely included by many files.

I have chosen to move the function prototypes to the new file as well,
because that means htup.h no longer needs to include tupdesc.h.  In
itself this doesn't have much effect in indirect inclusion of tupdesc.h
throughout the tree, because it's also required by execnodes.h; but it's
something to explore in the future, and it seemed best to do the htup.h
change now while I'm busy with it.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c219d9b0a55bcdf81b00da6bad24ac2bf3e53d20

Modified Files
--------------
contrib/dblink/dblink.c                       |    4 +-
contrib/file_fdw/file_fdw.c                   |    1 +
contrib/hstore/hstore_io.c                    |    1 +
contrib/hstore/hstore_op.c                    |    1 +
contrib/ltree/ltree_op.c                      |    1 +
contrib/pageinspect/heapfuncs.c               |    1 +
contrib/pageinspect/rawpage.c                 |    1 +
contrib/pg_buffercache/pg_buffercache_pages.c |    1 +
contrib/tablefunc/tablefunc.c                 |    1 +
contrib/tcn/tcn.c                             |    1 +
contrib/xml2/xpath.c                          |    1 +
src/backend/access/common/reloptions.c        |    1 +
src/backend/access/common/tupconvert.c        |    1 +
src/backend/access/common/tupdesc.c           |    1 +
src/backend/access/heap/hio.c                 |    1 +
src/backend/access/heap/pruneheap.c           |    1 +
src/backend/access/transam/twophase.c         |    2 +-
src/backend/access/transam/xlogfuncs.c        |    1 +
src/backend/bootstrap/bootstrap.c             |    1 +
src/backend/catalog/aclchk.c                  |    1 +
src/backend/catalog/dependency.c              |    1 +
src/backend/catalog/heap.c                    |    1 +
src/backend/catalog/indexing.c                |    1 +
src/backend/catalog/namespace.c               |    1 +
src/backend/catalog/objectaddress.c           |    1 +
src/backend/catalog/pg_aggregate.c            |    1 +
src/backend/catalog/pg_collation.c            |    1 +
src/backend/catalog/pg_constraint.c           |    1 +
src/backend/catalog/pg_conversion.c           |    1 +
src/backend/catalog/pg_db_role_setting.c      |    1 +
src/backend/catalog/pg_depend.c               |    1 +
src/backend/catalog/pg_enum.c                 |    1 +
src/backend/catalog/pg_inherits.c             |    1 +
src/backend/catalog/pg_largeobject.c          |    1 +
src/backend/catalog/pg_namespace.c            |    1 +
src/backend/catalog/pg_operator.c             |    1 +
src/backend/catalog/pg_proc.c                 |    1 +
src/backend/catalog/pg_range.c                |    1 +
src/backend/catalog/pg_shdepend.c             |    1 +
src/backend/catalog/pg_type.c                 |    1 +
src/backend/commands/aggregatecmds.c          |    1 +
src/backend/commands/alter.c                  |    1 +
src/backend/commands/collationcmds.c          |    1 +
src/backend/commands/comment.c                |    1 +
src/backend/commands/conversioncmds.c         |    1 +
src/backend/commands/copy.c                   |    1 +
src/backend/commands/createas.c               |    1 +
src/backend/commands/dbcommands.c             |    1 +
src/backend/commands/dropcmds.c               |    1 +
src/backend/commands/event_trigger.c          |    1 +
src/backend/commands/extension.c              |    1 +
src/backend/commands/foreigncmds.c            |    1 +
src/backend/commands/functioncmds.c           |    1 +
src/backend/commands/indexcmds.c              |    1 +
src/backend/commands/opclasscmds.c            |    1 +
src/backend/commands/operatorcmds.c           |    1 +
src/backend/commands/proclang.c               |    1 +
src/backend/commands/schemacmds.c             |    1 +
src/backend/commands/seclabel.c               |    1 +
src/backend/commands/sequence.c               |    1 +
src/backend/commands/tablespace.c             |    1 +
src/backend/commands/trigger.c                |    1 +
src/backend/commands/tsearchcmds.c            |    3 +-
src/backend/commands/typecmds.c               |    1 +
src/backend/commands/user.c                   |    1 +
src/backend/commands/vacuum.c                 |    1 +
src/backend/commands/vacuumlazy.c             |    1 +
src/backend/commands/variable.c               |    1 +
src/backend/executor/execAmi.c                |    1 +
src/backend/executor/execMain.c               |    1 +
src/backend/executor/execQual.c               |    1 +
src/backend/executor/execTuples.c             |    1 +
src/backend/executor/functions.c              |    1 +
src/backend/executor/nodeAgg.c                |    1 +
src/backend/executor/nodeHash.c               |    1 +
src/backend/executor/nodeHashjoin.c           |    1 +
src/backend/executor/nodeLockRows.c           |    1 +
src/backend/executor/nodeModifyTable.c        |    1 +
src/backend/executor/nodeSetOp.c              |    1 +
src/backend/executor/nodeSubplan.c            |    1 +
src/backend/executor/nodeWindowAgg.c          |    1 +
src/backend/executor/spi.c                    |    1 +
src/backend/foreign/foreign.c                 |    1 +
src/backend/nodes/tidbitmap.c                 |    2 +-
src/backend/optimizer/path/costsize.c         |    1 +
src/backend/optimizer/plan/planagg.c          |    1 +
src/backend/optimizer/plan/planner.c          |    1 +
src/backend/optimizer/plan/subselect.c        |    1 +
src/backend/optimizer/prep/prepunion.c        |    1 +
src/backend/optimizer/util/clauses.c          |    1 +
src/backend/optimizer/util/plancat.c          |    1 +
src/backend/parser/parse_coerce.c             |    1 +
src/backend/parser/parse_func.c               |    1 +
src/backend/parser/parse_node.c               |    1 +
src/backend/parser/parse_oper.c               |    1 +
src/backend/parser/parse_relation.c           |    1 +
src/backend/parser/parse_type.c               |    1 +
src/backend/parser/parse_utilcmd.c            |    1 +
src/backend/postmaster/autovacuum.c           |    1 +
src/backend/postmaster/pgstat.c               |    1 +
src/backend/rewrite/rewriteDefine.c           |    1 +
src/backend/rewrite/rewriteRemove.c           |    1 +
src/backend/rewrite/rewriteSupport.c          |    1 +
src/backend/storage/freespace/freespace.c     |    2 +-
src/backend/storage/lmgr/predicate.c          |    1 +
src/backend/storage/page/bufpage.c            |    2 +-
src/backend/tcop/fastpath.c                   |    1 +
src/backend/tcop/utility.c                    |    1 +
src/backend/tsearch/ts_selfuncs.c             |    1 +
src/backend/utils/adt/acl.c                   |    1 +
src/backend/utils/adt/array_selfuncs.c        |    1 +
src/backend/utils/adt/arrayfuncs.c            |    1 +
src/backend/utils/adt/datetime.c              |    1 +
src/backend/utils/adt/dbsize.c                |    1 +
src/backend/utils/adt/enum.c                  |    1 +
src/backend/utils/adt/format_type.c           |    1 +
src/backend/utils/adt/genfile.c               |    1 +
src/backend/utils/adt/json.c                  |    1 +
src/backend/utils/adt/lockfuncs.c             |    1 +
src/backend/utils/adt/pg_locale.c             |    1 +
src/backend/utils/adt/pgstatfuncs.c           |    1 +
src/backend/utils/adt/rangetypes_selfuncs.c   |    1 +
src/backend/utils/adt/regproc.c               |    1 +
src/backend/utils/adt/ri_triggers.c           |    3 +-
src/backend/utils/adt/rowtypes.c              |    1 +
src/backend/utils/adt/ruleutils.c             |    1 +
src/backend/utils/adt/selfuncs.c              |    1 +
src/backend/utils/adt/trigfuncs.c             |    1 +
src/backend/utils/adt/varbit.c                |    2 +-
src/backend/utils/adt/xml.c                   |    1 +
src/backend/utils/cache/evtcache.c            |    1 +
src/backend/utils/cache/inval.c               |    1 +
src/backend/utils/cache/lsyscache.c           |    1 +
src/backend/utils/cache/relcache.c            |    1 +
src/backend/utils/cache/syscache.c            |    1 +
src/backend/utils/cache/ts_cache.c            |    1 +
src/backend/utils/cache/typcache.c            |    1 +
src/backend/utils/fmgr/funcapi.c              |    1 +
src/backend/utils/init/miscinit.c             |    1 +
src/backend/utils/init/postinit.c             |    1 +
src/backend/utils/misc/superuser.c            |    1 +
src/backend/utils/sort/tuplesort.c            |    1 +
src/backend/utils/sort/tuplestore.c           |    1 +
src/backend/utils/time/combocid.c             |    2 +-
src/backend/utils/time/tqual.c                |    1 +
src/include/access/heapam.h                   |    1 +
src/include/access/heapam_xlog.h              |    1 +
src/include/access/htup.h                     |  632 +-----------------------
src/include/access/htup_details.h             |  657 +++++++++++++++++++++++++
src/include/access/reloptions.h               |    1 +
src/include/access/relscan.h                  |    1 +
src/include/access/tupconvert.h               |    1 +
src/include/access/tuptoaster.h               |    2 +-
src/include/executor/tuptable.h               |    1 +
src/include/utils/inval.h                     |    1 +
src/include/utils/lsyscache.h                 |    2 +
src/pl/plperl/plperl.c                        |    1 +
src/pl/plpgsql/src/pl_comp.c                  |    1 +
src/pl/plpgsql/src/pl_exec.c                  |    1 +
src/pl/plpgsql/src/pl_handler.c               |    1 +
src/pl/plpython/plpy_exec.c                   |    1 +
src/pl/plpython/plpy_main.c                   |    1 +
src/pl/plpython/plpy_procedure.c              |    1 +
src/pl/plpython/plpy_spi.c                    |    1 +
src/pl/plpython/plpy_typeio.c                 |    1 +
src/pl/plpython/plpy_typeio.h                 |    1 +
src/pl/tcl/pltcl.c                            |    1 +
167 files changed, 830 insertions(+), 639 deletions(-)

pgsql-committers by date

Next:From: Bruce MomjianDate: 2012-08-30 20:56:25
Subject: pgsql: Document that max_locks_per_transaction might need to beincreas
Previous:From: Bruce MomjianDate: 2012-08-30 20:27:05
Subject: pgsql: Remove configure flag --disable-shared,as it is no longer used

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group