pgAdmin III commit: Fix the check status after closing a message box

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix the check status after closing a message box
Date: 2012-08-24 17:53:01
Message-ID: E1T4y45-0007b7-LD@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fix the check status after closing a message box

The status has three possible values: YES, NO, and CANCEL. Most of the code
assume that the user clicks NO, and so the code checks for NO. But the user
can cancel the dialog, and as te code checks for NO, the code continues to
execute just as if the user clicked OK: table truncated, connection closed,
query killed without the explicit order of the user.

Patch from nikicat (https://github.com/nikicat), heavily changed by me.

Branch
------
REL-1_16_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=1b28cbdf4c1ef4d05fef9f52683d2fac143edc1e

Modified Files
--------------
pgadmin/debugger/ctlCodeWindow.cpp | 2 +-
pgadmin/dlg/dlgDomain.cpp | 2 +-
pgadmin/dlg/dlgIndex.cpp | 2 +-
pgadmin/dlg/dlgIndexConstraint.cpp | 2 +-
pgadmin/dlg/dlgProperty.cpp | 8 ++++----
pgadmin/dlg/dlgRole.cpp | 2 +-
pgadmin/dlg/dlgTable.cpp | 6 +++---
pgadmin/dlg/dlgTrigger.cpp | 2 +-
pgadmin/frm/frmBackup.cpp | 4 ++--
pgadmin/frm/frmBackupGlobals.cpp | 4 ++--
pgadmin/frm/frmBackupServer.cpp | 4 ++--
pgadmin/frm/frmMain.cpp | 4 ++--
pgadmin/frm/frmQuery.cpp | 2 +-
pgadmin/frm/frmReport.cpp | 2 +-
pgadmin/frm/frmRestore.cpp | 2 +-
pgadmin/frm/frmStatus.cpp | 12 ++++++------
pgadmin/schema/pgFunction.cpp | 2 +-
pgadmin/schema/pgRole.cpp | 4 ++--
pgadmin/schema/pgTable.cpp | 10 +++++-----
19 files changed, 38 insertions(+), 38 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2012-08-25 12:52:31 pgAdmin III commit: Fix the not-same-query process on the history combo
Previous Message Guillaume Lelarge 2012-08-24 14:56:35 Translations