Skip site navigation (1) Skip section navigation (2)

pgAdmin III commit: Fix the check status after closing a message box

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix the check status after closing a message box
Date: 2012-08-24 17:53:01
Message-ID: E1T4y45-0007b5-Jk@gothos.postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Fix the check status after closing a message box

The status has three possible values: YES, NO, and CANCEL. Most of the code
assume that the user clicks NO, and so the code checks for NO. But the user
can cancel the dialog, and as te code checks for NO, the code continues to
execute just as if the user clicked OK: table truncated, connection closed,
query killed without the explicit order of the user.

Patch from nikicat (https://github.com/nikicat), heavily changed by me.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=336f93afb80a3e8b993d497c8494c279a6f0a3f5

Modified Files
--------------
pgadmin/debugger/ctlCodeWindow.cpp |    2 +-
pgadmin/dlg/dlgDomain.cpp          |    2 +-
pgadmin/dlg/dlgIndex.cpp           |    2 +-
pgadmin/dlg/dlgIndexConstraint.cpp |    2 +-
pgadmin/dlg/dlgProperty.cpp        |    8 ++++----
pgadmin/dlg/dlgRole.cpp            |    2 +-
pgadmin/dlg/dlgTable.cpp           |    6 +++---
pgadmin/dlg/dlgTrigger.cpp         |    2 +-
pgadmin/frm/frmBackup.cpp          |    4 ++--
pgadmin/frm/frmBackupGlobals.cpp   |    4 ++--
pgadmin/frm/frmBackupServer.cpp    |    4 ++--
pgadmin/frm/frmMain.cpp            |    4 ++--
pgadmin/frm/frmQuery.cpp           |    2 +-
pgadmin/frm/frmReport.cpp          |    2 +-
pgadmin/frm/frmRestore.cpp         |    2 +-
pgadmin/frm/frmStatus.cpp          |   12 ++++++------
pgadmin/schema/pgFunction.cpp      |    2 +-
pgadmin/schema/pgRole.cpp          |    4 ++--
pgadmin/schema/pgTable.cpp         |   10 +++++-----
19 files changed, 38 insertions(+), 38 deletions(-)

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2012-08-25 12:52:31
Subject: pgAdmin III commit: Fix the not-same-query process on the historycombo
Previous:From: Guillaume LelargeDate: 2012-08-24 14:56:35
Subject: Translations

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group