Skip site navigation (1) Skip section navigation (2)

pgsql: Improve reporting of error situations in find_other_exec().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve reporting of error situations in find_other_exec().
Date: 2012-07-27 23:32:07
Message-ID: E1Suu0t-0004Oj-RQ@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Improve reporting of error situations in find_other_exec().

This function suppressed any stderr output from the called program, which
is unnecessary in the normal case and unhelpful in error cases.  It also
gave a rather opaque message along the lines of "fgets failure: Success"
in case the called program failed to return anything on stdout.  Since
we've seen multiple reports of people not understanding what's wrong when
pg_ctl reports this, improve the message.

Back-patch to all active branches.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/62d69045dd1c41bbcd8a7f78c7a4170e8381ca76

Modified Files
--------------
src/port/exec.c |   12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)

pgsql-committers by date

Next:From: Bruce MomjianDate: 2012-07-30 14:16:13
Subject: pgsql: Now that the diskchecker.pl author has updated the downloadlink
Previous:From: Bruce MomjianDate: 2012-07-27 01:25:41
Subject: pgsql: Update doc mention of diskchecker.pl to add URL for script;reta

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group