Skip site navigation (1) Skip section navigation (2)

pgsql: Fix statistics breakage from bgwriter/checkpointer processsplit

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix statistics breakage from bgwriter/checkpointer processsplit
Date: 2012-07-18 19:40:48
Message-ID: E1Sra76-0001pO-RI@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix statistics breakage from bgwriter/checkpointer process split.

ForwardFsyncRequest() supposed that it could only be called in regular
backends, which used to be true; but since the splitup of bgwriter and
checkpointer, it is also called in the bgwriter.  We do not want to count
such calls in pg_stat_bgwriter.buffers_backend statistics, so fix things
so that they aren't.

(It's worth noting here that this implies an alarmingly large increase in
the expected amount of cross-process fsync request traffic, which may well
mean that the process splitup was not such a hot idea.)

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/1e9326d6a3efcb5648a85c1653cc263bc787efa0

Modified Files
--------------
src/backend/postmaster/checkpointer.c |    6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

pgsql-committers by date

Next:From: Simon RiggsDate: 2012-07-18 20:18:33
Subject: Re: pgsql: Fix management of pendingOpsTable in auxiliary processes.
Previous:From: Tom LaneDate: 2012-07-18 19:38:03
Subject: pgsql: Fix management of pendingOpsTable in auxiliary processes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group