| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: plperl: Skip setting UTF8 flag when in SQL_ASCII encoding |
| Date: | 2012-07-10 19:53:18 |
| Message-ID: | E1SogUo-0002NF-Jf@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
plperl: Skip setting UTF8 flag when in SQL_ASCII encoding
When in SQL_ASCII encoding, strings passed around are not necessarily
UTF8-safe. We had already fixed this in some places, but it looks like
we missed some.
I had to backpatch Peter Eisentraut's a8b92b60 to 9.1 in order for this
patch to cherry-pick more cleanly.
Patch from Alex Hunsaker, tweaked by Kyotaro HORIGUCHI and myself.
Some desultory cleanup and comment addition by me, during patch review.
Per bug report from Christoph Berg in
20120209102116(dot)GA14429(at)msgid(dot)df7cb(dot)de
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/fc661f78c6007103604fc43e98622a71400b769f
Modified Files
--------------
src/pl/plperl/GNUmakefile | 2 +-
src/pl/plperl/Util.xs | 27 ++++++++++----
src/pl/plperl/expected/plperl.out | 10 -----
src/pl/plperl/plperl_helpers.h | 70 +++++++++++++++++++++++++++----------
src/pl/plperl/sql/plperl.sql | 9 -----
5 files changed, 71 insertions(+), 47 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-07-10 20:00:04 | pgsql: Fix ASCII case in pg_wchar2mule_with_len. |
| Previous Message | Alvaro Herrera | 2012-07-10 19:46:55 | pgsql: plperl: Skip setting UTF8 flag when in SQL_ASCII encoding |