Skip site navigation (1) Skip section navigation (2)

pgsql: Cope with smaller-than-normal BLCKSZ setting in SPGiST indexeso

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Cope with smaller-than-normal BLCKSZ setting in SPGiST indexeso
Date: 2012-06-26 18:36:38
Message-ID: E1Sjacw-0001lo-Ba@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Cope with smaller-than-normal BLCKSZ setting in SPGiST indexes on text.

The original coding failed miserably for BLCKSZ of 4K or less, as reported
by Josh Kupershmidt.  With the present design for text indexes, a given
inner tuple could have up to 256 labels (requiring either 3K or 4K bytes
depending on MAXALIGN), which means that we can't positively guarantee no
failures for smaller blocksizes.  But we can at least make it behave sanely
so long as there are few enough labels to fit on a page.  Considering that
btree is also more prone to "index tuple too large" failures when BLCKSZ is
small, it's not clear that we should expend more work than this on this
case.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/00e5844592a8c51ceee1682013b94ac50031a9ac

Modified Files
--------------
src/backend/access/spgist/spgtextproc.c |   12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)

pgsql-committers by date

Next:From: Robert HaasDate: 2012-06-26 20:06:14
Subject: pgsql: When LWLOCK_STATS is defined, count spindelays.
Previous:From: Robert HaasDate: 2012-06-26 17:35:20
Subject: pgsql: Make DROP FUNCTION hint more informative.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group