Ensure pg_ctl behaves sanely when data directory is not specified.
Commit aaa6e1def292cdacb6b27088898793b1b879fedf introduced multiple hazards
in the case where pg_ctl is executed with neither a -D switch nor any
PGDATA environment variable. It would dump core on machines which are
unforgiving about printf("%s", NULL), or failing that possibly give a
rather unhelpful complaint about being unable to execute "postgres -C",
rather than the logically prior complaint about not being told where the
data directory is.
Edmund Horner's report suggests that there is another, Windows-specific
hazard here, but I'm not the person to fix that; it would in any case only
be significant when trying to use a config-only PGDATA pointer.
src/bin/pg_ctl/pg_ctl.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
pgsql-committers by date
|Next:||From: Robert Haas||Date: 2012-06-12 13:54:19|
|Subject: pgsql: Copy-editing of release notes.|
|Previous:||From: Tom Lane||Date: 2012-06-12 01:56:06|
|Subject: pgsql: Fix pg_dump output to a named tar-file archive.|