Skip site navigation (1) Skip section navigation (2)

pgsql: Fix bug in gistRelocateBuildBuffersOnSplit().

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix bug in gistRelocateBuildBuffersOnSplit().
Date: 2012-05-18 16:39:29
Message-ID: E1SVQDB-00025X-Jv@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix bug in gistRelocateBuildBuffersOnSplit().

When we create a temporary copy of the old node buffer, in stack, we mustn't
leak that into any of the long-lived data structures. Before this patch,
when we called gistPopItupFromNodeBuffer(), it got added to the array of
"loaded buffers". After gistRelocateBuildBuffersOnSplit() exits, the
pointer added to the loaded buffers array points to garbage. Often that goes
unnotied, because when we go through the array of loaded buffers to unload
them, buffers with a NULL pageBuffer are ignored, which can often happen by
accident even if the pointer points to garbage.

This patch fixes that by marking the temporary copy in stack explicitly as
temporary, and refrain from adding buffers marked as temporary to the array
of loaded buffers.

While we're at it, initialize nodeBuffer->pageBlocknum to InvalidBlockNumber
and improve comments a bit. This isn't strictly necessary, but makes
debugging easier.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1d27dcf5781ac7baeda0584fd016efc8eab718b3

Modified Files
--------------
src/backend/access/gist/gistbuildbuffers.c |   20 ++++++++++++--------
src/include/access/gist_private.h          |    3 +++
2 files changed, 15 insertions(+), 8 deletions(-)

pgsql-committers by date

Next:From: Peter EisentrautDate: 2012-05-18 17:35:24
Subject: pgsql: Realign some --help output to have better spacing betweencolumn
Previous:From: Peter EisentrautDate: 2012-05-17 17:21:34
Subject: pgsql: file_fdw: Improve error message

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group