Skip site navigation (1) Skip section navigation (2)

pgsql: Don't override arguments set via options with positionalargumen

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't override arguments set via options with positionalargumen
Date: 2012-04-17 22:39:10
Message-ID: E1SKH3G-0003UR-Ga@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Don't override arguments set via options with positional arguments.

A number of utility programs were rather careless about paremeters
that can be set via both an option argument and a positional
argument. This leads to results which can violate the Principal
Of Least Astonishment. These changes refuse to use positional
arguments to override settings that have been made via positional
arguments. The changes are backpatched to all live branches.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/7bebb851920e74cda57b866ac2f64123b44323c5

Modified Files
--------------
src/bin/initdb/initdb.c      |    7 +++++--
src/bin/scripts/clusterdb.c  |   26 +++++++++++++++-----------
src/bin/scripts/createlang.c |   14 ++++++++++++--
src/bin/scripts/droplang.c   |   14 ++++++++++++--
src/bin/scripts/reindexdb.c  |   25 +++++++++++++++----------
src/bin/scripts/vacuumdb.c   |   27 ++++++++++++++++-----------
6 files changed, 75 insertions(+), 38 deletions(-)

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2012-04-17 23:08:01
Subject: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Previous:From: Andrew DunstanDate: 2012-04-17 21:29:25
Subject: Re: Bug tracker tool we need

pgsql-committers by date

Next:From: Robert HaasDate: 2012-04-17 23:08:01
Subject: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Previous:From: Andrew DunstanDate: 2012-04-17 22:39:01
Subject: pgsql: Don't override arguments set via options with positionalargumen

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group