pgsql: Measure epoch of timestamp-without-time-zone from local not UTC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Measure epoch of timestamp-without-time-zone from local not UTC
Date: 2012-04-10 16:05:38
Message-ID: E1SHdZa-0002Ou-9F@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Measure epoch of timestamp-without-time-zone from local not UTC midnight.

This patch reverts commit 191ef2b407f065544ceed5700e42400857d9270f
and thereby restores the pre-7.3 behavior of EXTRACT(EPOCH FROM
timestamp-without-tz). Per discussion, the more recent behavior was
misguided on a couple of grounds: it makes it hard to get a
non-timezone-aware epoch value for a timestamp, and it makes this one
case dependent on the value of the timezone GUC, which is incompatible
with having timestamp_part() labeled as immutable.

The other behavior is still available (in all releases) by explicitly
casting the timestamp to timestamp with time zone before applying EXTRACT.

This will need to be called out as an incompatible change in the 9.2
release notes. Although having mutable behavior in a function marked
immutable is clearly a bug, we're not going to back-patch such a change.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0d9819f7e3be3c4186f0398d007d2fef8809da6a

Modified Files
--------------
doc/src/sgml/func.sgml | 4 +++-
src/backend/utils/adt/timestamp.c | 25 +++----------------------
2 files changed, 6 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-04-10 17:36:01 pgsql: psql: Improve tab completion of WITH
Previous Message Heikki Linnakangas 2012-04-10 06:53:57 pgsql: Point the URL to PL/py directly to the page about the procedural