Skip site navigation (1) Skip section navigation (2)

pgsql: Don't bother copying empty support arrays in a zero-columnMerge

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't bother copying empty support arrays in a zero-columnMerge
Date: 2012-04-09 15:42:04
Message-ID: E1SHGjE-0006PG-P4@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Don't bother copying empty support arrays in a zero-column MergeJoin.

The case could not arise when this code was originally written, but it can
now (since we made zero-column MergeJoins work for the benefit of FULL JOIN
ON TRUE).  I don't think there is any actual bug here, but we might as well
treat it consistently with other uses of COPY_POINTER_FIELD().  Per comment
from Ashutosh Bapat.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d515365a611a58241019c59a62b0cb79584aa725

Modified Files
--------------
src/backend/nodes/copyfuncs.c |   11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2012-04-09 16:00:01
Subject: pgsql: Fix an Assert that turns out to be reachable after all.
Previous:From: Tom LaneDate: 2012-04-09 15:16:14
Subject: pgsql: Save a few cycles while creating "sticky" entries inpg_stat_sta

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group