Skip site navigation (1) Skip section navigation (2)

pgsql: Rename frontend keyword arrays to avoid conflict with backend.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Rename frontend keyword arrays to avoid conflict with backend.
Date: 2012-03-31 17:16:04
Message-ID: E1SE1uG-00082Q-70@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Rename frontend keyword arrays to avoid conflict with backend.

ecpg and pg_dump each contain keyword arrays with structure similar
to the backend's keyword array.  Up to now, we actually named those
arrays the same as the backend's and relied on parser/keywords.h
to declare them.  This seems a tad too cute, though, and it breaks
now that we need to PGDLLIMPORT-decorate the backend symbols.
Rename to avoid the problem.  Per buildfarm.

(It strikes me that maybe we should get rid of the separate keywords.c
files altogether, and just define these arrays in the modules that use
them, but that's a rather more invasive change.)

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c252a17d828756e2f7d635f69eace53aaf983420

Modified Files
--------------
src/bin/pg_dump/dumputils.c                 |    8 ++++++--
src/bin/pg_dump/keywords.c                  |    4 ++--
src/interfaces/ecpg/preproc/ecpg_keywords.c |   10 +++++++---
src/interfaces/ecpg/preproc/keywords.c      |    4 ++--
4 files changed, 17 insertions(+), 9 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2012-03-31 17:17:12
Subject: Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
Previous:From: Andrew DunstanDate: 2012-03-31 16:52:37
Subject: Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group