Skip site navigation (1) Skip section navigation (2)

pgsql: Improve the -l (limit) option recently added tocontrib/vacuumlo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve the -l (limit) option recently added tocontrib/vacuumlo
Date: 2012-03-20 23:05:58
Message-ID: E1SA87q-0002Si-0t@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Improve the -l (limit) option recently added to contrib/vacuumlo.

Instead of just stopping after removing an arbitrary subset of orphaned
large objects, commit and start a new transaction after each -l objects.
This is just as effective as the original patch at limiting the number of
locks used, and it doesn't require doing the OID collection process
repeatedly to get everything.  Since the option no longer changes the
fundamental behavior of vacuumlo, and it avoids a known server-side
limitation, enable it by default (with a default limit of 1000 LOs per
transaction).

In passing, be more careful about properly quoting the names of tables
and fields, and do some other cosmetic cleanup.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/64c604898e812aa93c124c666e8709fff1b8dd26

Modified Files
--------------
contrib/vacuumlo/vacuumlo.c |  131 +++++++++++++++++++++++++++++++------------
doc/src/sgml/vacuumlo.sgml  |   26 +++++----
2 files changed, 109 insertions(+), 48 deletions(-)

Responses

pgsql-hackers by date

Next:From: Qi HuangDate: 2012-03-21 02:22:49
Subject: Re: Gsoc2012 Idea --- Social Network database schema
Previous:From: AlexDate: 2012-03-20 22:18:44
Subject: Re: Another review of URI for libpq, v7 submission

pgsql-committers by date

Next:From: Robert HaasDate: 2012-03-21 01:26:54
Subject: pgsql: Add some CHECK_FOR_INTERRUPTS() calls to the heap-sort callpath
Previous:From: Alvaro HerreraDate: 2012-03-20 21:59:59
Subject: pgsql: pg_dump: get rid of die_horribly

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group