From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Be more clear when a new column name collides with a system colu |
Date: | 2012-01-26 17:47:24 |
Message-ID: | E1RqTPw-0000qo-3J@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Be more clear when a new column name collides with a system column name.
We now use the same error message for ALTER TABLE .. ADD COLUMN or
ALTER TABLE .. RENAME COLUMN that we do for CREATE TABLE. The old
message was accurate, but might be confusing to users not aware of our
system columns.
Vik Reykja, with some changes by me, and further proofreading by Tom Lane
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/2d1371d3ee5cf7e96d16fb503c27e060df9497f7
Modified Files
--------------
src/backend/commands/tablecmds.c | 64 ++++++++++++++++++++---------
src/test/regress/expected/alter_table.out | 2 +
src/test/regress/expected/errors.out | 2 +-
src/test/regress/sql/alter_table.sql | 2 +
4 files changed, 49 insertions(+), 21 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-01-26 19:45:56 | pgsql: Adjust tuplesort.c based on the fact that we never use the OS's |
Previous Message | Heikki Linnakangas | 2012-01-26 17:09:16 | pgsql: Fix sentence in docs: checkpoints are not done by bgwriter anymo |