Skip site navigation (1) Skip section navigation (2)

pgsql: Fix variable confusion in BufferSync().

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix variable confusion in BufferSync().
Date: 2012-01-06 13:36:27
Message-ID: E1Rj9y7-0007wv-Ee@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix variable confusion in BufferSync().

As noted by Heikki Linnakangas, the previous coding confused the "flags"
variable with the "mask" variable.  The affect of this appears to be that
unlogged buffers would get written out at every checkpoint rather than
only at shutdown time.  Although that's arguably an acceptable failure
mode, I'm back-patching this change, since it seems like a poor idea to
rely on this happening to work.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7e4911b2ae33acff7b85234b91372133ec6df9d4

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2012-01-06 15:49:26
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Previous:From: Andrew DunstanDate: 2012-01-06 13:34:30
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group