Skip site navigation (1) Skip section navigation (2)

pgsql: Revert the behavior of inet/cidr functions to not unpack thearg

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revert the behavior of inet/cidr functions to not unpack thearg
Date: 2011-12-12 08:29:23
Message-ID: E1Ra1GF-0004dt-0D@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Revert the behavior of inet/cidr functions to not unpack the arguments.

I forgot to change the functions to use the PG_GETARG_INET_PP() macro,
when I changed DatumGetInetP() to unpack the datum, like Datum*P macros
usually do. Also, I screwed up the definition of the PG_GETARG_INET_PP()
macro, and didn't notice because it wasn't used.

This fixes the memory leak when sorting inet values, as reported
by Jochen Erwied and debugged by Andres Freund. Backpatch to 8.3, like
the previous patch that broke it.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/6cf639dfbddbc44d027730ad1504886312bc905a

Modified Files
--------------
src/backend/utils/adt/network.c |   98 +++++++++++++++++++-------------------
src/include/utils/inet.h        |    2 +-
2 files changed, 50 insertions(+), 50 deletions(-)

Responses

pgsql-committers by date

Next:From: User FxjrDate: 2011-12-12 16:27:38
Subject: npgsql - Npgsql2: Fixed line endings.
Previous:From: Heikki LinnakangasDate: 2011-12-12 08:29:22
Subject: pgsql: Revert the behavior of inet/cidr functions to not unpack thearg

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group