Skip site navigation (1) Skip section navigation (2)

pgsql: Don't set reachedMinRecoveryPoint during crash recovery. Incras

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't set reachedMinRecoveryPoint during crash recovery. Incras
Date: 2011-12-09 13:55:51
Message-ID: E1RZ0vX-0005HQ-NZ@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Don't set reachedMinRecoveryPoint during crash recovery. In crash recovery,
we don't reach consistency before replaying all of the WAL. Rename the
variable to reachedConsistency, to make its intention clearer.

In master, that was an active bug because of the recent patch to
immediately PANIC if a reference to a missing page is found in WAL after
reaching consistency, as Tom Lane's test case demonstrated. In 9.1 and 9.0,
the only consequence was a misleading "consistent recovery state reached at
%X/%X" message in the log at the beginning of crash recovery (the database
is not consistent at that point yet). In 8.4, the log message was not
printed in crash recovery, even though there was a similar
reachedMinRecoveryPoint local variable that was also set early. So,
backpatch to 9.1 and 9.0.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e45057e0a7c4f5c6f1d662853c616eea26e9b0e4

Modified Files
--------------
src/backend/access/transam/xlog.c |   21 +++++++++++++++++----
1 files changed, 17 insertions(+), 4 deletions(-)

pgsql-committers by date

Next:From: Peter EisentrautDate: 2011-12-09 18:43:38
Subject: pgsql: Add ALTER FOREIGN DATA WRAPPER / RENAME and ALTER SERVER /RENAM
Previous:From: Heikki LinnakangasDate: 2011-12-09 12:26:54
Subject: pgsql: Cancel running query if it is detected that the connection toth

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group