Skip site navigation (1) Skip section navigation (2)

pgsql: Fix getTypeIOParam to support type record[].

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix getTypeIOParam to support type record[].
Date: 2011-12-01 17:44:51
Message-ID: E1RWAgl-0000Mb-A5@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix getTypeIOParam to support type record[].

Since record[] uses array_in, it needs to have its element type passed
as typioparam.  In HEAD and 9.1, this fix essentially reverts commit
9bc933b2125a5358722490acbc50889887bf7680, which was a hack that is no
longer needed since domains don't set their typelem anymore.  Before
that, adjust the logic so that only domains are excluded from being
treated like arrays, rather than assuming that only base types should
be included.  Add a regression test to demonstrate the need for this.
Per report from Maxim Boguk.

Back-patch to 8.4, where type record[] was added.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ac3dcca22e967ac4a899c4534b4b1c8e807ff71e

Modified Files
--------------
src/backend/utils/cache/lsyscache.c        |    5 ++---
src/test/regress/expected/polymorphism.out |   21 +++++++++++++++++++++
src/test/regress/sql/polymorphism.sql      |   15 +++++++++++++++
3 files changed, 38 insertions(+), 3 deletions(-)

pgsql-committers by date

Next:From: Josh BerkusDate: 2011-12-01 17:58:37
Subject: Re: pgsql: Add file-fdw documentation example.
Previous:From: Magnus HaganderDate: 2011-12-01 15:01:52
Subject: Re: pgsql: Add file-fdw documentation example.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group