Skip site navigation (1) Skip section navigation (2)

pgsql: Avoid possibly accessing off the end of memory in SJIS2004conve

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid possibly accessing off the end of memory in SJIS2004conve
Date: 2011-09-06 18:53:29
Message-ID: E1R10m1-0000h9-7G@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Avoid possibly accessing off the end of memory in SJIS2004 conversion.

The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when
only one remained in the string.  Since conversion functions aren't
supposed to assume null-terminated input, this poses a small risk of
fetching past the end of memory and incurring SIGSEGV.  No such crash has
been identified in the field, but we've certainly seen the equivalent
happen in other code paths, so patch this one all the way back.

Report and patch by Noah Misch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/623f77e9d1338720512430a0b8e824d7359739b8

Modified Files
--------------
.../euc2004_sjis2004/euc2004_sjis2004.c            |    8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2011-09-06 19:18:20
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Previous:From: Tom LaneDate: 2011-09-06 18:38:37
Subject: pgsql: Avoid possibly accessing off the end of memory inexamine_attrib

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group