Skip site navigation (1) Skip section navigation (2)

pgsql: Guard against using plperl's Makefile without specifying--with-

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Guard against using plperl's Makefile without specifying--with-
Date: 2011-09-05 00:07:51
Message-ID: E1R0Mj9-0005I4-BL@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Guard against using plperl's Makefile without specifying --with-perl.

The $(PERL) macro will be set by configure if it finds perl at all,
but $(perl_privlibexp) isn't configured unless you said --with-perl.
This results in confusing error messages if someone cd's into
src/pl/plperl and tries to build there despite the configure omission,
as reported by Tomas Vondra in bug #6198.  Add simple checks to
provide a more useful report, while not disabling other use of the
makefile such as "make clean".

Back-patch to 9.0, which is as far as the patch applies easily.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ed7eff89fd64021a2b4150c7d2caca488274c80b

Modified Files
--------------
src/pl/plperl/GNUmakefile |    6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

pgsql-committers by date

Next:From: Jeremy DrakeDate: 2011-09-05 07:07:49
Subject: Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Previous:From: Tom LaneDate: 2011-09-04 23:10:17
Subject: pgsql: Fix #include problems in 9.1 branch.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group