Skip site navigation (1) Skip section navigation (2)

pgsql: Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS
Date: 2011-08-24 19:17:12
Message-ID: E1QwIwq-0004FV-Da@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix pgxs.mk to always add  --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS.

The previous coding resulted in contrib modules unintentionally overriding
the use of CONTRIB_TESTDB.  There seems no particularly good reason to
allow that (after all, the makefile can set CONTRIB_TESTDB if that's really
what it intends).

In passing, document REGRESS_OPTS where the other pgxs.mk options are
documented.

Back-patch to 9.1 --- in prior versions, there were no cases of contrib
modules setting REGRESS_OPTS without including the --dbname switch, so
while the coding was fragile there was no actual bug.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/5354abb8f69734ff1c07cee5e29845b74d46e9d6

Modified Files
--------------
contrib/sepgsql/Makefile |    4 +++-
doc/src/sgml/extend.sgml |    9 +++++++++
src/makefiles/pgxs.mk    |    7 +++----
3 files changed, 15 insertions(+), 5 deletions(-)

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2011-08-24 21:35:15
Subject: pgsql: Update FK alternative test output to new whitespace rules
Previous:From: Peter EisentrautDate: 2011-08-24 18:43:56
Subject: pgsql: Build src/ before contrib/ in make world

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group