| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | pgAdmin III commit: Fix weird behaviour when changing column's collatio |
| Date: | 2011-07-19 07:28:59 |
| Message-ID: | E1Qj4jj-0006Fb-BB@gothos.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Fix weird behaviour when changing column's collation
If a user opens a table properties dialog, and tries to change the collation
of a column, he gets a DROP COLUMN followed by a ADD COLUMN statements.
If a user opens a column properties dialog (without the table properties
dialog first), and tries to change the collation, he gets nothing.
Both behaviour are wrong. We should get an ALTER TABLE... ALTER COLUMN...
TYPE... COLLATION... This patch fixes both issues.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5d43d434655c850ad1c2506036d0fbacde2f39a6
Author: Thom Brown <thom(at)linux(dot)com>
Modified Files
--------------
pgadmin/dlg/dlgColumn.cpp | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2011-07-19 07:32:35 | Re: Altering column collation |
| Previous Message | pgAdmin Trac | 2011-07-18 23:48:17 | Re: [pgAdmin III] #328: Column collation change has no effect |