From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin III commit: Overhaul of type attributes modification |
Date: | 2011-07-14 09:22:47 |
Message-ID: | E1QhI87-0004Aa-7m@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Overhaul of type attributes modification
If you add, delete, rename or change the type, collation or precision
of a composite type attribute, it deletes all of them then adds them
all back in. Obviously attribute additions, deletions and modifications
may only occur for types under PostgreSQL 9.1, but it's a bit extreme
to actually drop all types if you're adding a new one in, or just
removing one. Also, if you rename a type's element or change the type
of a type's element, it drops all attributes again then re-adds them,
just to have an attribute with a different name.
So this patch tries to do it right, with the minimum required queries.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=3912be3f48d7e48c3c479bd10f3e7a2f6735dab1
Author: Thom Brown <thom(at)linux(dot)com>
Modified Files
--------------
pgadmin/dlg/dlgType.cpp | 170 ++++++++++++++++++++++++++++------------
pgadmin/include/dlg/dlgType.h | 2 +-
2 files changed, 120 insertions(+), 52 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2011-07-14 09:22:48 | Re: Overhaul of type attributes modification |
Previous Message | Guillaume Lelarge | 2011-07-14 09:22:21 | pgAdmin III commit: Fix the collation clause on composite index |