Skip site navigation (1) Skip section navigation (2)

pgsql: Fix another oversight in logging of changes in postgresql.confs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix another oversight in logging of changes in postgresql.confs
Date: 2011-07-08 21:03:32
Message-ID: E1QfICy-0005zV-23@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix another oversight in logging of changes in postgresql.conf settings.

We were using GetConfigOption to collect the old value of each setting,
overlooking the possibility that it didn't exist yet.  This does happen
in the case of adding a new entry within a custom variable class, as
exhibited in bug #6097 from Maxim Boguk.

To fix, add a missing_ok parameter to GetConfigOption, but only in 9.1
and HEAD --- it seems possible that some third-party code is using that
function, so changing its API in a minor release would cause problems.
In 9.0, create a near-duplicate function instead.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9a9e530713d3ccf20a485c8cc61d6d599340d985

Modified Files
--------------
src/backend/utils/misc/guc-file.l |    6 ++--
src/backend/utils/misc/guc.c      |   40 +++++++++++++++++++++++++++++++++++++
src/include/utils/guc.h           |    1 +
3 files changed, 44 insertions(+), 3 deletions(-)

pgsql-committers by date

Next:From: Robert HaasDate: 2011-07-09 02:19:48
Subject: pgsql: Try to acquire relation locks in RangeVarGetRelid.
Previous:From: Tom LaneDate: 2011-07-08 21:03:31
Subject: pgsql: Fix another oversight in logging of changes in postgresql.confs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group