Fix another oversight in logging of changes in postgresql.conf settings.
We were using GetConfigOption to collect the old value of each setting,
overlooking the possibility that it didn't exist yet. This does happen
in the case of adding a new entry within a custom variable class, as
exhibited in bug #6097 from Maxim Boguk.
To fix, add a missing_ok parameter to GetConfigOption, but only in 9.1
and HEAD --- it seems possible that some third-party code is using that
function, so changing its API in a minor release would cause problems.
In 9.0, create a near-duplicate function instead.
src/backend/utils/misc/guc-file.l | 6 ++--
src/backend/utils/misc/guc.c | 40 +++++++++++++++++++++++++++++++++++++
src/include/utils/guc.h | 1 +
3 files changed, 44 insertions(+), 3 deletions(-)
pgsql-committers by date
|Next:||From: Robert Haas||Date: 2011-07-09 02:19:48|
|Subject: pgsql: Try to acquire relation locks in RangeVarGetRelid.|
|Previous:||From: Tom Lane||Date: 2011-07-08 21:03:31|
|Subject: pgsql: Fix another oversight in logging of changes in postgresql.confs|