Skip site navigation (1) Skip section navigation (2)

pgsql: Fix another oversight in logging of changes in postgresql.confs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix another oversight in logging of changes in postgresql.confs
Date: 2011-07-08 21:03:31
Message-ID: E1QfICx-0005zR-VP@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix another oversight in logging of changes in postgresql.conf settings.

We were using GetConfigOption to collect the old value of each setting,
overlooking the possibility that it didn't exist yet.  This does happen
in the case of adding a new entry within a custom variable class, as
exhibited in bug #6097 from Maxim Boguk.

To fix, add a missing_ok parameter to GetConfigOption, but only in 9.1
and HEAD --- it seems possible that some third-party code is using that
function, so changing its API in a minor release would cause problems.
In 9.0, create a near-duplicate function instead.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9d522cb35d8b4f266abadd0d019f68eb8802ae05

Modified Files
--------------
src/backend/commands/extension.c  |    6 +++---
src/backend/utils/misc/guc-file.l |    6 +++---
src/backend/utils/misc/guc.c      |   16 ++++++++++++----
src/include/utils/guc.h           |    3 ++-
4 files changed, 20 insertions(+), 11 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2011-07-08 21:03:32
Subject: pgsql: Fix another oversight in logging of changes in postgresql.confs
Previous:From: Heikki LinnakangasDate: 2011-07-08 16:06:02
Subject: pgsql: Introduce a pipe between postmaster and each backend,which can

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group