Skip site navigation (1) Skip section navigation (2)

pgsql: Remove assumptions that not-equals operators cannot be in anyop

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove assumptions that not-equals operators cannot be in anyop
Date: 2011-07-06 18:53:54
Message-ID: E1QeXEQ-0004TD-Vv@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Remove assumptions that not-equals operators cannot be in any opclass.

get_op_btree_interpretation assumed this in order to save some duplication
of code, but it's not true in general anymore because we added <> support
to btree_gist.  (We still assume it for btree opclasses, though.)

Also, essentially the same logic was baked into predtest.c.  Get rid of
that duplication by generalizing get_op_btree_interpretation so that it
can be used by predtest.c.

Per bug report from Denis de Bernardy and investigation by Jeff Davis,
though I didn't use Jeff's patch exactly as-is.

Back-patch to 9.1; we do not support this usage before that.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/14f67192c25a130a354f3e3e6db3dfd49d2f5c86

Modified Files
--------------
src/backend/optimizer/util/predtest.c |  191 +++++++++++----------------------
src/backend/parser/parse_expr.c       |   26 +++---
src/backend/utils/cache/lsyscache.c   |   97 ++++++++++-------
src/include/utils/lsyscache.h         |   12 ++-
4 files changed, 145 insertions(+), 181 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2011-07-06 18:53:55
Subject: pgsql: Remove assumptions that not-equals operators cannot be in anyop
Previous:From: Robert HaasDate: 2011-07-06 15:58:20
Subject: pgsql: Add \ir command to psql.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group