Skip site navigation (1) Skip section navigation (2)

pgsql: Remove usage of &PL_sv_undef in hashes and arrays

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove usage of &PL_sv_undef in hashes and arrays
Date: 2011-05-30 16:44:23
Message-ID: E1QR5Zn-0001TT-EY@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Remove usage of &PL_sv_undef in hashes and arrays

According to perlguts, &PL_sv_undef is not the right thing to use in
those cases because it doesn't behave the same way as an undef value via
Perl code.  Seems the intuitive way to deal with undef values is subtly
enough broken that it's hard to notice when misused.

The broken uses got inadvertently introduced in commit
87bb2ade2ce646083f39d5ab3e3307490211ad04 by Alexey Klyukin, Alex
Hunsaker and myself on 2011-02-17; no backpatch is necessary.

Per testing report from Greg Mullane.

Author: Alex Hunsaker

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7de38741c0438cdece0e22699de8ffd5797735fb

Modified Files
--------------
src/pl/plperl/plperl.c |   16 +++++++++++++---
1 files changed, 13 insertions(+), 3 deletions(-)

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2011-05-30 17:47:28
Subject: pgsql: The row-version chaining in Serializable Snapshot Isolationwas
Previous:From: Alvaro HerreraDate: 2011-05-30 16:44:22
Subject: pgsql: Make message more consistent

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group