Skip site navigation (1) Skip section navigation (2)

pgsql: Fix null-dereference crash in parse_xml_decl().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix null-dereference crash in parse_xml_decl().
Date: 2011-05-28 16:38:28
Message-ID: E1QQMWy-0000af-UU@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix null-dereference crash in parse_xml_decl().

parse_xml_decl's header comment says you can pass NULL for any unwanted
output parameter, but it failed to honor this contract for the "standalone"
flag.  The only currently-affected caller is xml_recv, so the net effect is
that sending a binary XML value containing a standalone parameter in its
xml declaration would crash the backend.  Per bug #6044 from Christopher
Dillard.

In passing, remove useless initializations of parse_xml_decl's output
parameters in xml_parse.

Back-patch to 8.3, where this code was introduced.

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d6a9e7a1e45a3569b3c3558b5817e78756224be2

Modified Files
--------------
src/backend/utils/adt/xml.c |   10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2011-05-28 16:38:29
Subject: pgsql: Fix null-dereference crash in parse_xml_decl().
Previous:From: C├ędric VillemainDate: 2011-05-28 07:05:17
Subject: Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group