Skip site navigation (1) Skip section navigation (2)

pgsql: Install defenses against overflow in BuildTupleHashTable().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Install defenses against overflow in BuildTupleHashTable().
Date: 2011-05-23 16:53:31
Message-ID: E1QOYNn-0002U9-SB@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Install defenses against overflow in BuildTupleHashTable().

The planner can sometimes compute very large values for numGroups, and in
cases where we have no alternative to building a hashtable, such a value
will get fed directly to BuildTupleHashTable as its nbuckets parameter.
There were two ways in which that could go bad.  First, BuildTupleHashTable
declared the parameter as "int" but most callers were passing "long"s,
so on 64-bit machines undetected overflow could occur leading to a bogus
negative value.  The obvious fix for that is to change the parameter to
"long", which is what I've done in HEAD.  In the back branches that seems a
bit risky, though, since third-party code might be calling this function.
So for them, just put in a kluge to treat negative inputs as INT_MAX.
Second, hash_create can go nuts with extremely large requested table sizes
(notably, my_log2 becomes an infinite loop for inputs larger than
LONG_MAX/2).  What seems most appropriate to avoid that is to bound the
initial table size request to work_mem.

This fixes bug #6035 reported by Daniel Schreiber.  Although the reported
case only occurs back to 8.4 since it involves WITH RECURSIVE, I think
it's a good idea to install the defenses in all supported branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/299d1716525c659f0e02840e31fbe4dea3cc796c

Modified Files
--------------
src/backend/executor/execGrouping.c |    8 ++++++--
src/backend/executor/nodeSubplan.c  |    4 ++--
src/include/executor/executor.h     |    2 +-
3 files changed, 9 insertions(+), 5 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2011-05-23 16:53:32
Subject: pgsql: Install defenses against overflow in BuildTupleHashTable().
Previous:From: Heikki LinnakangasDate: 2011-05-23 12:01:54
Subject: Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group