Skip site navigation (1) Skip section navigation (2)

pgsql: Clean up parsing of CREATE TRIGGER's argument list.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Clean up parsing of CREATE TRIGGER's argument list.
Date: 2011-05-11 18:44:11
Message-ID: E1QKEOJ-0008Rq-51@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Clean up parsing of CREATE TRIGGER's argument list.

Use ColLabel in place of ColId, so that reserved words are accepted as if
they were not reserved.  Also, remove BCONST and XCONST, which were never
documented as allowed.  Allowing those exposes to users an implementation
detail, namely the format in which the lexer outputs such constants, that
seems unwise to expose.

No documentation change needed, since this just makes the code act more
like you'd expect from reading the CREATE TRIGGER man page.

Per complaint from Szymon Guz and subsequent discussion.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6fc6686b48bc569b05ce711d18cf964498b217f2

Modified Files
--------------
src/backend/parser/gram.y |    4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2011-05-11 23:58:33
Subject: pgsql: Split PGC_S_DEFAULT into two values,for true boot_val vs comput
Previous:From: Heikki LinnakangasDate: 2011-05-11 11:51:19
Subject: pgsql: Shut down WAL receiver if it's still running at end ofrecovery.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group