Skip site navigation (1) Skip section navigation (2)

pgsql: Remove "make check" target in src/test/isolation/Makefile.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove "make check" target in src/test/isolation/Makefile.
Date: 2011-05-09 15:01:11
Message-ID: E1QJRxP-0007te-RL@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Remove "make check" target in src/test/isolation/Makefile.

This doesn't work as expected because the isolationtester program requires
libpq to already be installed.  While it works when you've already installed
libpq, having to already have done "make install" defeats most of the point
of a check with a temp installation.  And there are weird corner cases if
the dynamic linker picks up an old libpq.so from system library directories.
Remove the target (or more precisely, make it print a helpful message) so
people don't expect the case to work.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7886cc73ad12fb9b5a729b6c8152f11a309f5d65

Modified Files
--------------
src/test/isolation/Makefile |    9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)

pgsql-committers by date

Next:From: Bruce MomjianDate: 2011-05-10 01:05:13
Subject: pgsql: Update documentation to state there is three-value logic, not
Previous:From: Bruce MomjianDate: 2011-05-09 12:56:07
Subject: pgsql: In pg_upgrade, add status message about superuser check.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group