Skip site navigation (1) Skip section navigation (2)

pgsql: Code review for postmaster.pid contents changes.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review for postmaster.pid contents changes.
Date: 2011-01-14 00:03:56
Message-ID: E1PdX92-0006Ya-F7@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Code review for postmaster.pid contents changes.

Fix broken test for pre-existing postmaster, caused by wrong code for
appending lines to the lockfile; don't write a failed listen_address
setting into the lockfile; don't arbitrarily change the location of the
data directory in the lockfile compared to previous releases; provide more
consistent and useful definitions of the socket path and listen_address
entries; avoid assuming that pg_ctl has the same DEFAULT_PGSOCKET_DIR as
the postmaster; assorted code style improvements.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=52948169bcddf443b76d6ff1806259b153a2ac04

Modified Files
--------------
doc/src/sgml/storage.sgml           |   11 ++-
src/backend/port/ipc_test.c         |    4 +-
src/backend/port/sysv_shmem.c       |   13 ++-
src/backend/postmaster/postmaster.c |   35 ++++---
src/backend/utils/init/miscinit.c   |   77 ++++++++-------
src/bin/pg_ctl/pg_ctl.c             |  185 ++++++++++++++++++-----------------
src/include/miscadmin.h             |   28 +++++-
7 files changed, 194 insertions(+), 159 deletions(-)

pgsql-committers by date

Next:From: Magnus HaganderDate: 2011-01-14 11:37:22
Subject: pgsql: Exit from base backups when shutdown is requested
Previous:From: Tom LaneDate: 2011-01-13 19:34:13
Subject: pgsql: Revert incorrect memory-conservation hack ininheritance_planner

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group