Skip site navigation (1) Skip section navigation (2)

pgsql: Revert incorrect memory-conservation hack ininheritance_planner

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revert incorrect memory-conservation hack ininheritance_planner
Date: 2011-01-13 19:34:13
Message-ID: E1PdSw1-0002sd-KZ@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Revert incorrect memory-conservation hack in inheritance_planner().

This reverts commit d1001a78ce612a16ea622b558f5fc2b68c45ab4c of 2010-12-05,
which was broken as reported by Jeff Davis.  The problem is that the
individual planning steps may have side-effects on substructures of
PlannerGlobal, not only the current PlannerInfo root.  Arranging to keep
all such side effects in the main planning context is probably possible,
but it would change this from a quick local hack into a wide-ranging and
rather fragile endeavor.  Which it's not worth.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f0f36045b2e3d037bb7647d84373404fa4ba9588

Modified Files
--------------
src/backend/optimizer/plan/planner.c |   68 +++++++--------------------------
1 files changed, 15 insertions(+), 53 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2011-01-14 00:03:56
Subject: pgsql: Code review for postmaster.pid contents changes.
Previous:From: Magnus HaganderDate: 2011-01-13 17:53:20
Subject: pgsql: Make sure walsender state is only read while holding thespinloc

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group