Skip site navigation (1) Skip section navigation (2)

pgsql: Fix the logic in libpqrcv_receive() to determine if there'sany

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix the logic in libpqrcv_receive() to determine if there'sany
Date: 2011-01-13 16:31:00
Message-ID: E1PdQ4i-0000NZ-OS@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix the logic in libpqrcv_receive() to determine if there's any incoming data
that can be read without blocking. It used to conclude that there isn't, even
though there was data in the socket receive buffer. That lead walreceiver to
flush the WAL after every received chunk, potentially causing big performance
issues.

Backpatch to 9.0, because the performance impact can be very significant.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a5a02a744555789ab8390dbf57271e9d07127602

Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c            |   35 +++++++++----------
1 files changed, 17 insertions(+), 18 deletions(-)

pgsql-committers by date

Next:From: Bruce MomjianDate: 2011-01-13 17:09:42
Subject: pgsql: More libpq documentation adjustments from Leslie S Satenstein,r
Previous:From: Peter EisentrautDate: 2011-01-13 07:33:31
Subject: pgsql: Don't run regression tests in SQL_ASCII encoding by default

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group