pgsql: Fix contrib/seg's GiST picksplit method.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix contrib/seg's GiST picksplit method.
Date: 2010-12-16 02:25:03
Message-ID: E1PT3Wh-000510-DL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix contrib/seg's GiST picksplit method.

This patch replaces Guttman's generalized split method with a simple
sort-by-center-points algorithm. Since the data is only one-dimensional
we don't really need the slow and none-too-stable Guttman method.

This is in part a bug fix, since seg has the same size_alpha versus
size_beta typo that was recently fixed in contrib/cube. It seems
prudent to apply this rather aggressive fix only in HEAD, though.
Back branches will just get the typo fix.

Alexander Korotkov, reviewed by Yeb Havinga

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2a6ebe70fb2f7ec97a08dc07214fe2ca571d2780

Modified Files
--------------
contrib/seg/seg.c | 194 +++++++++++++++++++++-------------------------------
1 files changed, 78 insertions(+), 116 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-12-16 04:51:47 pgsql: Fix up getopt() reset management so it works on recent mingw.
Previous Message Robert Haas 2010-12-16 02:10:52 pgsql: Some copy editing of pg_read_binary_file() patch.