Skip site navigation (1) Skip section navigation (2)

pgsql: Fix two small bugs in new gistget.c logic.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix two small bugs in new gistget.c logic.
Date: 2010-12-04 18:48:04
Message-ID: E1POx9Q-0006qh-3e@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix two small bugs in new gistget.c logic.

1. Complain, rather than silently doing nothing, if an "invalid" tuple
is found on a leaf page.  Per off-list discussion with Heikki.

2. Fix oversight in code that removes a GISTSearchItem from the search
queue: we have to reset lastHeap if this was the last heap item in the
parent GISTSearchTreeItem.  Otherwise subsequent additions will do the
wrong thing.  This was probably masked in early testing because in typical
cases the parent item would now be completely empty and would be deleted on
next call.  You'd need a queued non-leaf page at exactly the same distance
as a heap tuple to expose the bug.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d1f5a92e18dcfc750e9d338597e66af920aad99e

Modified Files
--------------
src/backend/access/gist/gistget.c |    5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-12-05 20:11:03
Subject: pgsql: Reduce memory consumption inside inheritance_planner().
Previous:From: Peter EisentrautDate: 2010-12-04 15:36:45
Subject: pgsql: Make output width consistent for all ways of invoking aregressi

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group