pgsql: Still more tweaking of git_changelog.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Still more tweaking of git_changelog.
Date: 2010-09-26 05:51:32
Message-ID: E1Ozk96-0001p9-AO@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Still more tweaking of git_changelog.

1. Don't assume there's only one candidate match; check them all and use the
one with the closest timestamp. Avoids funny output when someone makes
several successive commits with the same log message, as certain people
have been known to do.

2. When the same commit (with the same SHA1) is reachable from multiple
branch tips, don't report it for all the branches; instead report it only
for the first such branch. Given our development practices, this case
arises only for commits that occurred before a given branch split off from
master. The original coding blamed old commits on *all* the branches,
which isn't terribly useful; the new coding blames such a commit only on
master.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=899beb78941aa955aac2e19cb82458c6f4c7dd52

Modified Files
--------------
src/tools/git_changelog | 24 +++++++++++++++++++-----
1 files changed, 19 insertions(+), 5 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2010-09-26 10:36:47 Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Previous Message Tom Lane 2010-09-26 04:22:58 pgsql: Fix some more bugs in git_changelog.

Browse pgsql-hackers by date

  From Date Subject
Next Message Massa, Harald Armin 2010-09-26 09:42:11 documentation udpates to pgupgrade.html
Previous Message Itagaki Takahiro 2010-09-26 04:35:41 Re: Help with User-defined function in PostgreSQL with Visual C++